Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ci-visibility): expect observed test result #9123

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Apr 29, 2024

This change broadens an assertion to expect the result sometimes observed in main-branch CI failures https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60433/workflows/bc3f1e10-28ef-4fb5-91c0-300b90a4a021/jobs/3795336

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 29, 2024
@emmettbutler emmettbutler requested a review from a team as a code owner April 29, 2024 14:54
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: emmett.butler/civis-request-calls
Commit report: f78c06b
Test service: dd-trace-py

✅ 0 Failed, 117525 Passed, 56565 Skipped, 3h 2m 39.46s Total duration (6h 53m 44.19s time saved)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 6.61%. Comparing base (704aac0) to head (f78c06b).
Report is 25 commits behind head on main.

Files Patch % Lines
tests/integration/test_integration_civisibility.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9123       +/-   ##
===========================================
- Coverage   78.64%    6.61%   -72.04%     
===========================================
  Files        1254     1233       -21     
  Lines      117809   117223      -586     
===========================================
- Hits        92653     7755    -84898     
- Misses      25156   109468    +84312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmettbutler emmettbutler enabled auto-merge (squash) April 29, 2024 15:52
@pr-commenter
Copy link

pr-commenter bot commented Apr 29, 2024

Benchmarks

Benchmark execution time: 2024-04-29 15:56:23

Comparing candidate commit f78c06b in PR branch emmett.butler/civis-request-calls with baseline commit 33bd59f in branch main.

Found 2 performance improvements and 7 performance regressions! Performance is the same for 192 metrics, 9 unstable metrics.

scenario:flasksimple-appsec-telemetry

  • 🟩 execution_time [-284.205µs; -246.191µs] or [-4.344%; -3.763%]

scenario:httppropagationextract-medium_valid_headers_all

  • 🟥 max_rss_usage [+494.659KB; +708.746KB] or [+2.399%; +3.437%]

scenario:otelspan-start-finish

  • 🟩 max_rss_usage [-750.105KB; -669.159KB] or [-3.332%; -2.972%]

scenario:sethttpmeta-no-collectipvariant

  • 🟥 max_rss_usage [+611.044KB; +762.754KB] or [+2.922%; +3.647%]

scenario:sethttpmeta-obfuscation-no-query

  • 🟥 max_rss_usage [+711.637KB; +789.956KB] or [+3.410%; +3.786%]

scenario:sethttpmeta-useragentvariant_not_exists_1

  • 🟥 max_rss_usage [+728.346KB; +813.389KB] or [+3.490%; +3.898%]

scenario:tracer-large

  • 🟥 max_rss_usage [+688.667KB; +768.280KB] or [+3.168%; +3.534%]

scenario:tracer-medium

  • 🟥 max_rss_usage [+541.678KB; +612.165KB] or [+2.616%; +2.957%]

scenario:tracer-small

  • 🟥 max_rss_usage [+713.299KB; +787.066KB] or [+3.462%; +3.820%]

@emmettbutler emmettbutler merged commit 02f7908 into main Apr 29, 2024
54 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/civis-request-calls branch April 29, 2024 16:34
github-actions bot pushed a commit that referenced this pull request May 22, 2024
This change broadens an assertion to expect the result sometimes
observed in main-branch CI failures
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60433/workflows/bc3f1e10-28ef-4fb5-91c0-300b90a4a021/jobs/3795336

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 02f7908)
github-actions bot pushed a commit that referenced this pull request May 22, 2024
This change broadens an assertion to expect the result sometimes
observed in main-branch CI failures
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60433/workflows/bc3f1e10-28ef-4fb5-91c0-300b90a4a021/jobs/3795336

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 02f7908)
emmettbutler added a commit that referenced this pull request May 22, 2024
Backport 02f7908 from #9123 to 2.8.

This change broadens an assertion to expect the result sometimes
observed in main-branch CI failures
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60433/workflows/bc3f1e10-28ef-4fb5-91c0-300b90a4a021/jobs/3795336

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
emmettbutler added a commit that referenced this pull request May 22, 2024
Backport 02f7908 from #9123 to 2.7.

This change broadens an assertion to expect the result sometimes
observed in main-branch CI failures
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60433/workflows/bc3f1e10-28ef-4fb5-91c0-300b90a4a021/jobs/3795336

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.7 backport 2.8 changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants