Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ci-visibility): expect observed test result [backport 2.8] #9351

Merged
merged 1 commit into from
May 22, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented May 22, 2024

Backport 02f7908 from #9123 to 2.8.

This change broadens an assertion to expect the result sometimes observed in main-branch CI failures https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60433/workflows/bc3f1e10-28ef-4fb5-91c0-300b90a4a021/jobs/3795336

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This change broadens an assertion to expect the result sometimes
observed in main-branch CI failures
https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/60433/workflows/bc3f1e10-28ef-4fb5-91c0-300b90a4a021/jobs/3795336

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 02f7908)
@github-actions github-actions bot requested a review from a team as a code owner May 22, 2024 16:46
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label May 22, 2024
@github-actions github-actions bot requested a review from erikayasuda May 22, 2024 16:46
@emmettbutler emmettbutler enabled auto-merge (squash) May 22, 2024 16:52
@Yun-Kim Yun-Kim added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels May 22, 2024
@emmettbutler emmettbutler merged commit 1cc7cfc into 2.8 May 22, 2024
14 of 15 checks passed
@emmettbutler emmettbutler deleted the backport-9123-to-2.8 branch May 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants