Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): pin version of echion dependency [backport 2.8] #9178

Merged
merged 2 commits into from
May 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 7, 2024

Backport b860ab0 from #9142 to 2.8.

Profiling introduced a "stack v2" feature recently in order to address reports of segmentation faults.

As part of this, we rely on the echion codebase. We'll be making changes to echion in response to certain customer issues, with the corresponding fixes needing to be backported.

This PR simply tightens up the build process for stack v2 in order to pin the dependency version more precisely. It's a developmental PR for future fixups.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Profiling introduced a "stack v2" feature recently in order to address
reports of segmentation faults.

As part of this, we rely on the
[echion](https://github.com/P403n1x87/echion) codebase. We'll be making
changes to echion in response to certain customer issues, with the
corresponding fixes needing to be backported.

This PR simply tightens up the build process for stack v2 in order to
pin the dependency version more precisely. It's a developmental PR for
future fixups.

## Checklist

- [X] Change(s) are motivated and described in the PR description
- [X] Testing strategy is described if automated tests are not included
in the PR
- [X] Risks are described (performance impact, potential for breakage,
maintainability)
- [X] Change is maintainable (easy to change, telemetry, documentation)
- [X] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [X] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [X] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [X] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: sanchda <sanchda@users.noreply.github.com>
(cherry picked from commit b860ab0)
@github-actions github-actions bot requested a review from a team as a code owner May 7, 2024 11:06
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label May 7, 2024
@github-actions github-actions bot requested a review from brettlangdon May 7, 2024 11:06
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 7, 2024

Datadog Report

Branch report: backport-9142-to-2.8
Commit report: 92d6bbc
Test service: dd-trace-py

✅ 0 Failed, 168 Passed, 888 Skipped, 13m 22.59s Total duration (1h 8m 50.3s time saved)

@pr-commenter
Copy link

pr-commenter bot commented May 7, 2024

Benchmarks

Benchmark execution time: 2024-05-07 13:52:57

Comparing candidate commit 92d6bbc in PR branch backport-9142-to-2.8 with baseline commit a5ee561 in branch 2.8.

Found 8 performance improvements and 13 performance regressions! Performance is the same for 180 metrics, 9 unstable metrics.

scenario:coreapiscenario-context_with_data_listeners

  • 🟥 max_rss_usage [+558.202KB; +714.015KB] or [+2.612%; +3.342%]

scenario:coreapiscenario-context_with_data_no_listeners

  • 🟥 max_rss_usage [+553.493KB; +695.787KB] or [+2.590%; +3.256%]

scenario:coreapiscenario-core_dispatch_listeners

  • 🟥 max_rss_usage [+466.047KB; +711.963KB] or [+2.176%; +3.323%]

scenario:coreapiscenario-core_dispatch_only_all_listeners

  • 🟥 max_rss_usage [+533.995KB; +746.415KB] or [+2.498%; +3.491%]

scenario:flasksimple-appsec-get

  • 🟩 execution_time [-252.406µs; -201.201µs] or [-3.878%; -3.092%]

scenario:httppropagationextract-all_styles_all_headers

  • 🟥 max_rss_usage [+700.962KB; +759.262KB] or [+3.292%; +3.566%]

scenario:httppropagationextract-b3_headers

  • 🟥 max_rss_usage [+677.579KB; +726.530KB] or [+3.186%; +3.416%]

scenario:httppropagationextract-empty_headers

  • 🟩 max_rss_usage [-714.026KB; -659.363KB] or [-3.251%; -3.002%]

scenario:httppropagationextract-full_t_id_datadog_headers

  • 🟥 max_rss_usage [+772.526KB; +1153.004KB] or [+3.703%; +5.527%]

scenario:httppropagationextract-wsgi_large_header_no_matches

  • 🟥 max_rss_usage [+889.720KB; +972.731KB] or [+4.225%; +4.619%]

scenario:httppropagationextract-wsgi_medium_header_no_matches

  • 🟥 max_rss_usage [+929.852KB; +989.533KB] or [+4.425%; +4.709%]

scenario:httppropagationextract-wsgi_valid_headers_basic

  • 🟥 max_rss_usage [+676.949KB; +931.141KB] or [+3.220%; +4.429%]

scenario:httppropagationinject-ids_only

  • 🟥 max_rss_usage [+503.778KB; +682.424KB] or [+2.359%; +3.196%]

scenario:httppropagationinject-with_all

  • 🟩 max_rss_usage [-967.446KB; -926.545KB] or [-4.404%; -4.218%]

scenario:httppropagationinject-with_priority_and_origin

  • 🟩 max_rss_usage [-748.690KB; -704.980KB] or [-3.412%; -3.213%]

scenario:httppropagationinject-with_sampling_priority

  • 🟥 max_rss_usage [+692.326KB; +726.529KB] or [+3.261%; +3.422%]

scenario:httppropagationinject-with_tags_invalid

  • 🟥 max_rss_usage [+723.958KB; +760.842KB] or [+3.406%; +3.580%]

scenario:otelspan-start-finish

  • 🟩 max_rss_usage [-727.536KB; -681.488KB] or [-3.127%; -2.929%]

scenario:otelspan-start-finish-telemetry

  • 🟩 max_rss_usage [-717.450KB; -630.544KB] or [-3.070%; -2.698%]

scenario:sethttpmeta-obfuscation-worst-case-implicit-query

  • 🟩 max_rss_usage [-763.845KB; -454.305KB] or [-3.408%; -2.027%]

scenario:span-start-finish

  • 🟩 max_rss_usage [-743.766KB; -540.739KB] or [-3.387%; -2.462%]

@sanchda sanchda enabled auto-merge (squash) May 7, 2024 13:00
@sanchda sanchda merged commit 9f0aa46 into 2.8 May 7, 2024
68 of 97 checks passed
@sanchda sanchda deleted the backport-9142-to-2.8 branch May 7, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants