-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(profiling): pin version of echion dependency [backport 2.8] #9178
Conversation
Profiling introduced a "stack v2" feature recently in order to address reports of segmentation faults. As part of this, we rely on the [echion](https://github.com/P403n1x87/echion) codebase. We'll be making changes to echion in response to certain customer issues, with the corresponding fixes needing to be backported. This PR simply tightens up the build process for stack v2 in order to pin the dependency version more precisely. It's a developmental PR for future fixups. ## Checklist - [X] Change(s) are motivated and described in the PR description - [X] Testing strategy is described if automated tests are not included in the PR - [X] Risks are described (performance impact, potential for breakage, maintainability) - [X] Change is maintainable (easy to change, telemetry, documentation) - [X] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [X] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [X] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [X] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [ ] Title is accurate - [ ] All changes are related to the pull request's stated goal - [ ] Description motivates each change - [ ] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [ ] Testing strategy adequately addresses listed risks - [ ] Change is maintainable (easy to change, telemetry, documentation) - [ ] Release note makes sense to a user of the library - [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [ ] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: sanchda <sanchda@users.noreply.github.com> (cherry picked from commit b860ab0)
Datadog ReportBranch report: ✅ 0 Failed, 168 Passed, 888 Skipped, 13m 22.59s Total duration (1h 8m 50.3s time saved) |
BenchmarksBenchmark execution time: 2024-05-07 13:52:57 Comparing candidate commit 92d6bbc in PR branch Found 8 performance improvements and 13 performance regressions! Performance is the same for 180 metrics, 9 unstable metrics. scenario:coreapiscenario-context_with_data_listeners
scenario:coreapiscenario-context_with_data_no_listeners
scenario:coreapiscenario-core_dispatch_listeners
scenario:coreapiscenario-core_dispatch_only_all_listeners
scenario:flasksimple-appsec-get
scenario:httppropagationextract-all_styles_all_headers
scenario:httppropagationextract-b3_headers
scenario:httppropagationextract-empty_headers
scenario:httppropagationextract-full_t_id_datadog_headers
scenario:httppropagationextract-wsgi_large_header_no_matches
scenario:httppropagationextract-wsgi_medium_header_no_matches
scenario:httppropagationextract-wsgi_valid_headers_basic
scenario:httppropagationinject-ids_only
scenario:httppropagationinject-with_all
scenario:httppropagationinject-with_priority_and_origin
scenario:httppropagationinject-with_sampling_priority
scenario:httppropagationinject-with_tags_invalid
scenario:otelspan-start-finish
scenario:otelspan-start-finish-telemetry
scenario:sethttpmeta-obfuscation-worst-case-implicit-query
scenario:span-start-finish
|
Backport b860ab0 from #9142 to 2.8.
Profiling introduced a "stack v2" feature recently in order to address reports of segmentation faults.
As part of this, we rely on the echion codebase. We'll be making changes to echion in response to certain customer issues, with the corresponding fixes needing to be backported.
This PR simply tightens up the build process for stack v2 in order to pin the dependency version more precisely. It's a developmental PR for future fixups.
Checklist
changelog/no-changelog
is set@DataDog/apm-tees
.Reviewer Checklist