Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setuptools_scm): backport setuptools_scm version scheme to guess-next-dev [backport 2.9] #9180

Merged
merged 1 commit into from
May 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 7, 2024

Backport 99b3eca from #8953 to 2.9.

Prior to this change, setuptools_scm reported the version for patch releases as the next minor release. Afterwards, versions are patch releases (as expected).

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

(cherry picked from commit 1ffb660)

@github-actions github-actions bot requested a review from a team as a code owner May 7, 2024 12:26
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. CI labels May 7, 2024
@github-actions github-actions bot requested a review from P403n1x87 May 7, 2024 12:26
@brettlangdon brettlangdon changed the title fix(setuptools_scm): backport setuptools_scm version scheme to guess-next-dev [backport 2.8] [backport 2.9] fix(setuptools_scm): backport setuptools_scm version scheme to guess-next-dev [backport 2.9] May 7, 2024
@brettlangdon brettlangdon enabled auto-merge (squash) May 7, 2024 12:28
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented May 7, 2024

Datadog Report

Branch report: backport-8953-to-2.9
Commit report: 1328f4d
Test service: dd-trace-py

✅ 0 Failed, 173637 Passed, 1207 Skipped, 11h 1m 54.39s Total duration (26m 14.65s time saved)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (2.9@d687695). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             2.9    #9180   +/-   ##
======================================
  Coverage       ?    6.59%           
======================================
  Files          ?     1242           
  Lines          ?   118065           
  Branches       ?        0           
======================================
  Hits           ?     7781           
  Misses         ?   110284           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…next-dev [backport 2.8] (#8953)

Prior to this change, setuptools_scm reported the version for patch
releases as the next minor release. Afterwards, versions are patch
releases (as expected).

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

(cherry picked from commit 1ffb660)

Co-authored-by: Teague Bick <teague.bick@datadoghq.com>
(cherry picked from commit 99b3eca)
@brettlangdon brettlangdon merged commit fa564f7 into 2.9 May 7, 2024
160 of 167 checks passed
@brettlangdon brettlangdon deleted the backport-8953-to-2.9 branch May 7, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants