fix(ci_visibility): use default tracer in CI Visibility (#9328)

[romainkomorndatadog]

This reverts commit 2008dd7 and reinstates the changes from #9016 .

Checklist

• Change(s) are motivated and described in the PR description
• Testing strategy is described if automated tests are not included in the PR
• Risks are described (performance impact, potential for breakage, maintainability)
• Change is maintainable (easy to change, telemetry, documentation)
• Library release note guidelines are followed or label changelog/no-changelog is set
• Documentation is included (in-code, generated user docs, public corp docs)
• Backport labels are set (if applicable)
• If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

• Title is accurate
• All changes are related to the pull request's stated goal
• Description motivates each change
• Avoids breaking API changes
• Testing strategy adequately addresses listed risks
• Change is maintainable (easy to change, telemetry, documentation)
• Release note makes sense to a user of the library
• Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
• Backport labels are set in a manner that is consistent with the release branch maintenance policy

[romainkomorndatadog]

After chatting with @brettlangdon , we're leaning towards not backporting this to 2.9.

I suppose if #9349 merges and backports into 2.9 first, then this change would be safe enough to backport as well.

[datadog-dd-trace-py-rkomorn]

Datadog Report

Branch report: romain.komorn/CIVIS-9440/revert_revert
Commit report: 2cb5100
Test service: dd-trace-py

✅ 0 Failed, 174675 Passed, 1104 Skipped, 11h 18m 2.7s Total duration (20m 18.32s time saved)

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 10.28%. Comparing base (66b96e9) to head (2cb5100).
Report is 2 commits behind head on main.

Files	Patch %	Lines
tests/contrib/pytest/test_pytest_snapshot.py	0.00%	11 Missing ⚠️
ddtrace/internal/ci_visibility/recorder.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9350       +/-   ##
===========================================
- Coverage   76.02%   10.28%   -65.75%     
===========================================
  Files        1294     1264       -30     
  Lines      122816   120958     -1858     
===========================================
- Hits        93370    12439    -80931     
- Misses      29446   108519    +79073     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emmettbutler]

Does dogweb CI pass when run against this commit?

[romainkomorndatadog]

@emmettbutler

Does dogweb CI pass when run against this commit?

Not yet, it needs #9349 first.

[emmettbutler]

I'm going to hold off on approving this until there's a clear indication that it's been tested against dogweb CI.

[romainkomorndatadog]

@emmettbutler this never broke dogweb CI, dogweb CI broke because of the bug fixed in #9349 and dogweb's use of tracer.configure().

Bluntly put, dogweb CI isn't this PR's problem and it shouldn't be blocking this fix. We shouldn't be blocking a release because of this.

[emmettbutler]

@romainkomorndatadog thanks for clarifying!

[datadog-dd-trace-py-rkomorn]

Datadog Report

Branch report: romain.komorn/CIVIS-9440/revert_revert
Commit report: 63b7178
Test service: dd-trace-py

✅ 0 Failed, 118195 Passed, 59404 Skipped, 4h 16m 34.18s Total duration (7m 21.71s time saved)

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-06-13 16:50:03

Comparing candidate commit 63b7178 in PR branch romain.komorn/CIVIS-9440/revert_revert with baseline commit 128b80d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

[romainkomorndatadog]

Well, crap. This needed to merge after #9349 .