Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci_visibility): use default tracer in CI Visibility (#9328) [backport 2.10] #9544

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

github-actions[bot]
Copy link

Backport 99c74e6 from #9350 to 2.10.

This reverts commit 2008dd7 and reinstates the changes from #9016 .

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This reverts commit 2008dd7 and
reinstates the changes from #9016 .

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Emmett Butler <723615+emmettbutler@users.noreply.github.com>
(cherry picked from commit 99c74e6)
@emmettbutler emmettbutler enabled auto-merge (squash) June 13, 2024 17:01
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 13, 2024

Datadog Report

Branch report: backport-9350-to-2.10
Commit report: 0808468
Test service: dd-trace-py

✅ 0 Failed, 133412 Passed, 44148 Skipped, 7h 5m 10.88s Total duration (3h 14m 44.53s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jun 13, 2024

Benchmarks

Benchmark execution time: 2024-06-19 11:49:45

Comparing candidate commit 903da6e in PR branch backport-9350-to-2.10 with baseline commit 70b27a2 in branch 2.10.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@emmettbutler
Copy link
Collaborator

This should not be merged until #9349 has been backported to 2.10

@emmettbutler emmettbutler marked this pull request as draft June 14, 2024 13:38
@romainkomorndatadog romainkomorndatadog marked this pull request as ready for review June 19, 2024 10:44
@romainkomorndatadog
Copy link
Collaborator

Should merge after #9576 .

@gnufede gnufede enabled auto-merge (squash) June 21, 2024 15:48
@gnufede gnufede merged commit 641cf99 into 2.10 Jun 21, 2024
194 of 203 checks passed
@gnufede gnufede deleted the backport-9350-to-2.10 branch June 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants