Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade pytest for requests framework test #9362

Merged
merged 3 commits into from
May 24, 2024

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented May 23, 2024

Avoids these kind of errors in the CI: https://github.com/DataDog/dd-trace-py/actions/runs/9204318180/job/25317642591?pr=9344#step:8:62

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI labels May 23, 2024
@gnufede gnufede marked this pull request as ready for review May 23, 2024 08:42
@gnufede gnufede requested a review from a team as a code owner May 23, 2024 08:42
@gnufede gnufede requested a review from emmettbutler May 23, 2024 08:42
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: gnufede/fix-requests-framework-test
Commit report: e7866f2
Test service: dd-trace-py

✅ 0 Failed, 146462 Passed, 27795 Skipped, 9h 9m 37.64s Total duration (1h 55m 25.67s time saved)
❄️ 10 New Flaky

New Flaky Tests (10)

  • test_cmdi - test_pygoat.py - Last Failure

    Expand for error
     HTTPConnectionPool(host='0.0.0.0', port=9126): Max retries exceeded with url: /test/session/start?test_session_token=pygoat_test (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f46eabcafd0>: Failed to establish a new connection: [Errno 111] Connection refused'))
    
  • test_cmdi - test_pygoat.py - Last Failure

    Expand for error
     HTTPConnectionPool(host='0.0.0.0', port=9126): Max retries exceeded with url: /test/session/start?test_session_token=pygoat_test (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f01145eb690>: Failed to establish a new connection: [Errno 111] Connection refused'))
    
  • test_insecure_cookie - test_pygoat.py - Last Failure

    Expand for error
     HTTPConnectionPool(host='0.0.0.0', port=9126): Max retries exceeded with url: /test/session/start?test_session_token=pygoat_test (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f01146fc650>: Failed to establish a new connection: [Errno 111] Connection refused'))
    
  • test_nohttponly_cookie - test_pygoat.py - Last Failure

    Expand for error
     HTTPConnectionPool(host='0.0.0.0', port=9126): Max retries exceeded with url: /test/session/start?test_session_token=pygoat_test (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f01146c0250>: Failed to establish a new connection: [Errno 111] Connection refused'))
    
  • test_sqli - test_pygoat.py - Last Failure

    Expand for error
     HTTPConnectionPool(host='0.0.0.0', port=9126): Max retries exceeded with url: /test/session/start?test_session_token=pygoat_test (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f46eab310a0>: Failed to establish a new connection: [Errno 111] Connection refused'))
    

@pr-commenter
Copy link

pr-commenter bot commented May 23, 2024

Benchmarks

Benchmark execution time: 2024-05-23 15:38:38

Comparing candidate commit 2211e79 in PR branch gnufede/fix-requests-framework-test with baseline commit 3de0cf5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 209 metrics, 9 unstable metrics.

@emmettbutler
Copy link
Collaborator

@gnufede the django framework tests fail when I re-run them. I thought at first that they were timing out, but that doesn't seem to be the case.

@gnufede gnufede merged commit 609a306 into main May 24, 2024
85 of 87 checks passed
@gnufede gnufede deleted the gnufede/fix-requests-framework-test branch May 24, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants