Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(appsec): skip pygoat tests because they are failing on main #9507

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Jun 10, 2024

These tests recently started failing reliably on the main branch, so they're skipped here to keep CI unblocked.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 10, 2024
@emmettbutler emmettbutler requested a review from a team as a code owner June 10, 2024 19:34
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 10, 2024

Datadog Report

Branch report: emmett.butler/pygoat-failures
Commit report: c899816
Test service: dd-trace-py

✅ 0 Failed, 144831 Passed, 34121 Skipped, 7h 39m 57.33s Total duration (1h 55m 39.6s time saved)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 10.27%. Comparing base (844117e) to head (c899816).
Report is 8 commits behind head on main.

Files Patch % Lines
...ts/appsec/integrations/pygoat_tests/test_pygoat.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9507       +/-   ##
===========================================
- Coverage   75.88%   10.27%   -65.61%     
===========================================
  Files        1315     1285       -30     
  Lines      124706   123109     -1597     
===========================================
- Hits        94633    12650    -81983     
- Misses      30073   110459    +80386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmettbutler emmettbutler merged commit 29d7ae5 into main Jun 10, 2024
221 of 223 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/pygoat-failures branch June 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants