Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(appsec): skip pygoat tests because they are failing on main #9507

Merged
merged 1 commit into from
Jun 10, 2024
Merged

ci(appsec): skip pygoat tests because they are failing on main #9507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/appsec/integrations/pygoat_tests/test_pygoat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,26 +92,30 @@ class InnerBreakException(Exception):
return False


@pytest.mark.skip("Failing reliably on main")
def test_insecure_cookie(client):
payload = {"name": "admin", "pass": "adminpassword", "csrfmiddlewaretoken": client.csrftoken}
reply = client.pygoat_session.post(PYGOAT_URL + "/sql_lab", data=payload, headers=TESTAGENT_HEADERS)
assert reply.status_code == 200
assert vulnerability_in_traces("INSECURE_COOKIE", client.agent_session)


@pytest.mark.skip("Failing reliably on main")
def test_nohttponly_cookie(client):
payload = {"email": "test@test.com", "csrfmiddlewaretoken": client.csrftoken}
reply = client.pygoat_session.post(PYGOAT_URL + "/otp", data=payload, headers=TESTAGENT_HEADERS)
assert reply.status_code == 200
assert vulnerability_in_traces("NO_HTTPONLY_COOKIE", client.agent_session)


@pytest.mark.skip("Failing reliably on main")
def test_weak_random(client):
reply = client.pygoat_session.get(PYGOAT_URL + "/otp?email=test%40test.com", headers=TESTAGENT_HEADERS)
assert reply.status_code == 200
assert vulnerability_in_traces("WEAK_RANDOMNESS", client.agent_session)


@pytest.mark.skip("Failing reliably on main")
def test_weak_hash(client):
payload = {"username": "admin", "password": "adminpassword", "csrfmiddlewaretoken": client.csrftoken}
reply = client.pygoat_session.post(
Expand All @@ -121,13 +125,15 @@ def test_weak_hash(client):
assert vulnerability_in_traces("WEAK_HASH", client.agent_session)


@pytest.mark.skip("Failing reliably on main")
def test_cmdi(client):
payload = {"domain": "google.com && ls", "csrfmiddlewaretoken": client.csrftoken}
reply = client.pygoat_session.post(PYGOAT_URL + "/cmd_lab", data=payload, headers=TESTAGENT_HEADERS)
assert reply.status_code == 200
assert vulnerability_in_traces("COMMAND_INJECTION", client.agent_session)


@pytest.mark.skip("Failing reliably on main")
def test_sqli(client):
payload = {"name": "admin", "pass": "anything' OR '1' ='1", "csrfmiddlewaretoken": client.csrftoken}
reply = client.pygoat_session.post(PYGOAT_URL + "/sql_lab", data=payload, headers=TESTAGENT_HEADERS)
Expand All @@ -153,6 +159,7 @@ def test_ssrf1(client, tracer, iast_span_defaults):
assert vulnerability_in_traces("SSRF", client.agent_session)


@pytest.mark.skip("Failing reliably on main")
def test_ssrf2(client, tracer, span_defaults):
from ddtrace.appsec._iast._taint_tracking import OriginType
from ddtrace.appsec._iast._taint_tracking import taint_pyobject
Expand Down
Loading