Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asm): add propagation for grpc server sources #9598

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Jun 20, 2024

Description

Adds tainting support for gRPC server sources.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
@juanjux juanjux added the ASM Application Security Monitoring label Jun 20, 2024
@juanjux juanjux self-assigned this Jun 20, 2024
@juanjux juanjux requested review from a team as code owners June 20, 2024 13:58
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jun 20, 2024

Datadog Report

Branch report: juanjux/APPSEC-53066-iast-grpc-server
Commit report: 11f5e64
Test service: dd-trace-py

✅ 0 Failed, 113697 Passed, 1326 Skipped, 22m 34.96s Total duration (11m 5.36s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2024

Benchmarks

Benchmark execution time: 2024-06-20 16:28:05

Comparing candidate commit e9ac435 in PR branch juanjux/APPSEC-53066-iast-grpc-server with baseline commit f33856b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.

@juanjux juanjux merged commit c463bb2 into main Jun 21, 2024
117 of 124 checks passed
@juanjux juanjux deleted the juanjux/APPSEC-53066-iast-grpc-server branch June 21, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants