-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(framework tests): bump sanic
version in framework test
#9834
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 100 Passed, 245 Skipped, 4m 29.19s Total duration (5m 38.99s time saved) |
BenchmarksBenchmark execution time: 2024-07-16 17:40:20 Comparing candidate commit ed23e7b in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 212 metrics, 2 unstable metrics. scenario:sethttpmeta-useragentvariant_exists_2
scenario:sethttpmeta-useragentvariant_exists_3
|
|
sanic
version in framework test
The Sanic framework tests have been failing for the
test_asgi.py
tests (see example here).Bumping the pinned version from 22.12 to 24.6 resolves these errors.
Checklist
Reviewer Checklist