Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(framework tests): bump sanic version in framework test #9834

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Jul 15, 2024

The Sanic framework tests have been failing for the test_asgi.py tests (see example here).

Bumping the pinned version from 22.12 to 24.6 resolves these errors.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jul 15, 2024

Datadog Report

Branch report: erikayasuda/framework-test-fix
Commit report: 2c863a3
Test service: dd-trace-py

✅ 0 Failed, 100 Passed, 245 Skipped, 4m 29.19s Total duration (5m 38.99s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jul 15, 2024

Benchmarks

Benchmark execution time: 2024-07-16 17:40:20

Comparing candidate commit ed23e7b in PR branch erikayasuda/framework-test-fix with baseline commit e5e8140 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 212 metrics, 2 unstable metrics.

scenario:sethttpmeta-useragentvariant_exists_2

  • 🟥 max_rss_usage [+1.455MB; +1.525MB] or [+7.141%; +7.487%]

scenario:sethttpmeta-useragentvariant_exists_3

  • 🟥 max_rss_usage [+1.504MB; +1.564MB] or [+7.386%; +7.678%]

Copy link

github-actions bot commented Jul 16, 2024

CODEOWNERS have been resolved as:

.github/workflows/test_frameworks.yml                                   @DataDog/python-guild @DataDog/apm-core-python

@erikayasuda erikayasuda changed the title trigger failures with my feature branch chore(framework tests): bump sanic version in framework test Jul 16, 2024
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 16, 2024
@erikayasuda erikayasuda marked this pull request as ready for review July 16, 2024 17:32
@erikayasuda erikayasuda requested review from a team as code owners July 16, 2024 17:32
@brettlangdon brettlangdon enabled auto-merge (squash) July 16, 2024 17:33
@brettlangdon brettlangdon merged commit 76e78c9 into main Jul 16, 2024
107 of 110 checks passed
@brettlangdon brettlangdon deleted the erikayasuda/framework-test-fix branch July 16, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants