-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD_PROFILING_NO_EXTENSION required when building native extensions using a nix environment #1774
Comments
Not good! Thanks @langsharpe for reporting. I'll investigate and report back. Feel free to keep using |
…without JIT The profiling native extension relies on the Ruby MJIT headers on 2.6+. But these headers are not available in Rubies that were compiled with JIT disabled. To avoid impacting these users (e.g. making them explicitly need to install with `DD_PROFILING_NO_EXTENSION=true`), let's automatically skip the extension when we detect that the JIT was disabled. In the future, we can explore using `debase-ruby_core_source`for these Ruby versions, if we still want to support these users. Fixes #1774
…without JIT The profiling native extension relies on the Ruby MJIT headers on 2.6+. But these headers are not available in Rubies that were compiled with JIT disabled. To avoid impacting these users (e.g. making them explicitly need to install with `DD_PROFILING_NO_EXTENSION=true`), let's automatically skip the extension when we detect that the JIT was disabled. In the future, we can explore using `debase-ruby_core_source` for these Ruby versions, if we still want to support these users. Fixes #1774
I've been investigating this, and the issue is that the nixos Ruby binary has been built without JIT support, which the profiling native extension relies on. I've opened #1776 to add auto-detection of this situation, and skip building the extension, so that installs are not impacted. Thanks a lot @langsharpe for the awesome report. Just to sum up the current status:
Hope this works for you! |
Thanks, @ivoanjo. For us, this was a developer experience problem and not a production problem. Thank you for the fast and knowledgeable response. |
@langsharpe thanks again for the report. The fix has been released as 0.54.1 so you'll no longer need |
As requested in the help message, here is an example of the new native extension failing to build. Perhaps the nix package doesn't include the required files?
Let me know if there is anything I can do to help.
The text was updated successfully, but these errors were encountered: