-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix container parsing for k8s cgroup #1487
Conversation
Before merging this, I want to investigate a report for Fargate 1.4... if there's a change to be made, it'd be easier to add it to this PR. |
Codecov Report
@@ Coverage Diff @@
## master #1487 +/- ##
=======================================
Coverage 98.23% 98.24%
=======================================
Files 863 863
Lines 41582 41681 +99
=======================================
+ Hits 40849 40948 +99
Misses 733 733
Continue to review full report at Codecov.
|
@delner not sure if it's helpful, but I have a repo https://github.com/DataDog/profile-ruby-app-on-amazon-ecs-experiment (internal link, sorry!) with some scaffolding to deploy stuff to ecs/eks, it may come in handy. |
8ac0f05
to
e8226ce
Compare
Okay, fixed one more scenario regarding Fargate 1.4+ cgroups. This should be ready for review. |
Adds support for:
.slice
and.scope
from IDs)Also includes some minor refactoring for tests and a slightly more permissive expectation (so it doesn't break with
pry
.)