Default to disable http.client_ip tag collection
#2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
previously approved these changes
Oct 19, 2022
lloeki
force-pushed
the
default-to-disable-client-ip
branch
from
0c751bf
to
a42806d
Compare
github-actions
bot
added
appsec
lloeki
dismissed
TonyCTHsu’s stale review
It was a bit early to review as more changes were needed.
lloeki
force-pushed
the
default-to-disable-client-ip
branch
from
9fe33f4
to
2d0c039
Compare
|
Rebased to benefit from #2327 |
marcotc
approved these changes
Oct 25, 2022
lloeki
commented
Oct 25, 2022
Comment on lines
57
to
58
| ENV_DISABLED = 'DD_TRACE_CLIENT_IP_HEADER_DISABLED'.freeze | ||
| ENV_ENABLED = 'DD_TRACE_CLIENT_IP_HEADER_ENABLED'.freeze | ||
| ENV_DISABLED = 'DD_TRACE_CLIENT_IP_HEADER_DISABLED'.freeze # TODO: deprecated, remove later |
There was a problem hiding this comment.
I think there might be a mistake in the original one and it's supposed to be DD_TRACE_CLIENT_IP_ENABLED. Checking.
This removes the `_HEADER` part inconsistent with the configuration setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change
http.client_ip(implemented in #2248) collection to opt-in.Motivation
http.client_ipshould not be collected by default by the tracer.