Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Headers::Ext #3300

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Remove deprecated Headers::Ext #3300

merged 1 commit into from
Dec 1, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 1, 2023

2.0 Upgrade Guide notes
Deprecated constants at Datadog::Tracing::Distributed::Headers::Ext have been removed. These constants have been moved to Datadog::Tracing::Distributed::Datadog and Datadog::Tracing::Distributed::B3.

Motivation:

Datadog::Tracing::Distributed::Headers::Ext was a dumping ground for all distributed headers. The constants have been moved to their respective propagation styles instead.

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner December 1, 2023 01:31
@marcotc marcotc self-assigned this Dec 1, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b46fe7) 97.99% compared to head (99aa0f1) 97.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.0    #3300   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files        1248     1248           
  Lines       72058    72058           
  Branches     3401     3401           
=======================================
  Hits        70616    70616           
  Misses       1442     1442           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit 32812d2 into 2.0 Dec 1, 2023
152 checks passed
@marcotc marcotc deleted the remove-deprecated-ext branch December 1, 2023 20:11
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@marcotc marcotc mentioned this pull request Apr 2, 2024
2 tasks
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants