Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq: Remove tag_args option #3396

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

2.0 Upgrade Guide notes

🚨 Sidekiq: tag_args option is removed, use quantize instead

If you were setting this option with true, change your code from

    Datadog.configure do |c|
      c.tracing.instrument :sidekiq, tag_args: true
    end

to

    Datadog.configure do |c|
      c.tracing.instrument :sidekiq, quantize: { args: { show: :all } }
    end

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jan 24, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review January 24, 2024 12:40
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner January 24, 2024 12:40
@TonyCTHsu TonyCTHsu self-assigned this Jan 24, 2024
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner January 24, 2024 12:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (277b90f) 98.10% compared to head (e552244) 98.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3396      +/-   ##
==========================================
- Coverage   98.10%   98.10%   -0.01%     
==========================================
  Files        1252     1252              
  Lines       72342    72325      -17     
  Branches     3387     3386       -1     
==========================================
- Hits        70974    70957      -17     
  Misses       1368     1368              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu merged commit 52aded8 into 2.0 Jan 25, 2024
151 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-sidekiq-tag-args branch January 25, 2024 15:13
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants