Provide commit sha for RelEnv #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3713 +/- ##
=======================================
Coverage 97.91% 97.91%
=======================================
Files 1246 1246
Lines 74999 74999
Branches 3627 3627
=======================================
Hits 73436 73436
Misses 1563 1563 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
force-pushed
the
tonycthsu/relenv-consistent-sha
branch
from
a4c9887
to
b6e83b0
Compare
BenchmarksBenchmark execution time: 2024-07-12 11:07:07 Comparing candidate commit 9cf93d3 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 2 unstable metrics. scenario:Propagation - Datadog
|
|
Uhh, I like this idea! Fingers crossed it can work nicely :) |
TonyCTHsu
force-pushed
the
tonycthsu/relenv-consistent-sha
branch
2 times, most recently
from
9d11c36
to
9d556a4
Compare
TonyCTHsu
force-pushed
the
tonycthsu/relenv-consistent-sha
branch
from
9d556a4
to
53beb04
Compare
ivoanjo
approved these changes
Jul 12, 2024
| @@ -232,9 +232,27 @@ onboarding_tests: | |||
| variables: | |||
| PRODUCT_NAME: auto_inject-ruby | |||
|
|
|||
| save_versions: | |||
| image: $DOCKER_REGISTRY/images/mirror/ruby:3.2.2 | |||
There was a problem hiding this comment.
Minor: We may be able to use a simpler image without Ruby ;)
randomanderson
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In order to release
1.x-stable, we need to update commit sha for RelEnv deploymentWhat does this PR do?
This PR attempt to provide the compute the latest commit sha, so we don't need to manually update RelEnv.