Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby LSP support for VSCode (and possibly others) #3777

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

lloeki
Copy link
Contributor

@lloeki lloeki commented Jul 11, 2024

What does this PR do?

  • Add a :dev Gemfile group for development-oriented gems.
  • Add the ruby-lsp gem to that group.
  • Remove the gem/group for appraisals.
  • Suggest the Ruby LSP VSCode extension for this workspace.

Motivation:

This gem is used by the VSCode Ruby LSP extension from Shopify, and possibly other IDEs as well. Having it in the Gemfile for development provides a good out-of-the-box experience.

Additional Notes:

A few other extensions are recommended as well:

  • EditorConfig: since we use that
  • Steep and RBS: the official extensions

The suggestion should only pop up once and the user is free to install or dismiss.

How to test the change?

Using VS Code with the Ruby LSP extension should provide an immediate OOTB experience that uses the LSP.

If not installed already, the extension should be suggested by VSCode as a recommendation, which is also free to be dismissed.

This gem is used by the VSCode `Ruby LSP` extension from Shopify.
@lloeki lloeki requested a review from a team as a code owner July 11, 2024 09:28
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (b428d21) to head (81c3037).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3777   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files        1246     1246           
  Lines       74999    74999           
  Branches     3627     3627           
=======================================
+ Hits        73434    73435    +1     
+ Misses       1565     1564    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anmarchenko anmarchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use the same gem and VSCode extension for datadog-ci-rb, it works great

@lloeki lloeki merged commit 2a662b0 into master Jul 11, 2024
170 checks passed
@lloeki lloeki deleted the lloeki/add-ruby-lsp branch July 11, 2024 11:02
@github-actions github-actions bot added this to the 2.2.0 milestone Jul 11, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.2.0, 2.3.0 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants