Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete OnlyOnce during patching #3900

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Sep 10, 2024

What does this PR do?

Internal refactoring for some instrumentation

  1. Remove redundant OnlyOnce guard for during patching httprb, httpclient and presto ( OnlyOnce guard has already applied by its parent Datadog::Tracing::Contrib::Patcher)
  2. Remove redundant ActionCable rescue
  3. Change lograge incompatibility to warn

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Sep 10, 2024
@TonyCTHsu TonyCTHsu added dev/refactor Involves refactoring existing components dev/internal Other internal work that does not need to be included in the changelog labels Sep 10, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review September 10, 2024 09:11
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner September 10, 2024 09:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.87%. Comparing base (bccbcd6) to head (d5017d4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3900      +/-   ##
==========================================
+ Coverage   97.86%   97.87%   +0.01%     
==========================================
  Files        1279     1279              
  Lines       76522    76502      -20     
  Branches     3747     3747              
==========================================
- Hits        74890    74879      -11     
+ Misses       1632     1623       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Sep 10, 2024

Benchmarks

Benchmark execution time: 2024-09-10 09:56:03

Comparing candidate commit d5017d4 in PR branch tonycthsu/remove-obsolete-only-once with baseline commit bccbcd6 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 22 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-1.542op/s; -1.523op/s] or [-21.391%; -21.118%]

@TonyCTHsu TonyCTHsu merged commit ebd0c3e into master Sep 10, 2024
191 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-obsolete-only-once branch September 10, 2024 10:47
@anmarchenko anmarchenko added this to the 2.4.0 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog dev/refactor Involves refactoring existing components integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants