WEB-2929 | Image and CI updates #16423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devindford
changed the title
davidejones
approved these changes
Jan 11, 2023
hestonhoffman
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes our CI files to utilize the newest version of the shared image, as well as new commands for deploy. It also adds environments where missing for certain jobs that will need it for deploys.
Motivation
We're attempting to have one image used for both corp and docs
Preview
https://docs-staging.datadoghq.com/devin.ford/WEB-2929/
Additional Notes
This one will just require some QA and a lot of combing over the gitlab-ci as another set of eyes to ensure all functions have been converted and that anything running the
deploy_sitecommand has an environment tagged in the job.Reviewer checklist