Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLOB-1016] replace prompt/completion tokens with i/o tokens #23812

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

ncybul
Copy link
Contributor

@ncybul ncybul commented Jun 21, 2024

What does this PR do? What is the motivation?

We are in the middle of a transition from ingesting prompt / completion tokens to input / output tokens. This PR updates the docs to reflect the new expected names for token metrics.

Merge instructions

  • Please merge after reviewing

Additional notes

@ncybul ncybul requested a review from a team as a code owner June 21, 2024 20:51
@ncybul ncybul changed the title [MLOB] replace prompt/completion tokens with i/o tokens [MLOB-1016] replace prompt/completion tokens with i/o tokens Jun 21, 2024
@hestonhoffman
Copy link
Contributor

Is this ready to merge once the checks pass?

@ncybul
Copy link
Contributor Author

ncybul commented Jun 24, 2024

Is this ready to merge once the checks pass?

I added one more update that was missing, but after the checks pass now, this should be ready to merge. Thanks!

@jhgilbert jhgilbert merged commit 82d35be into master Jun 24, 2024
13 checks passed
@jhgilbert jhgilbert deleted the nicole-cybul/update-token-metric-field-names branch June 24, 2024 18:39
@jhgilbert
Copy link
Contributor

Merged by request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants