Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added function to deal with redirection of HTTP requests #200

Merged
merged 7 commits into from
Jan 27, 2020
Merged

Added function to deal with redirection of HTTP requests #200

merged 7 commits into from
Jan 27, 2020

Conversation

Azoam
Copy link
Contributor

@Azoam Azoam commented Nov 5, 2019

Currently there is no handling for redirection of http requests. This function will add redirection handling.

@gzussa gzussa requested a review from a team November 8, 2019 17:10
@github-actions
Copy link

github-actions bot commented Jan 4, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days.
Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity.

@github-actions github-actions bot added the stale Stale - Bot reminder label Jan 4, 2020
@github-actions github-actions bot closed this Jan 11, 2020
@dabcoder dabcoder reopened this Jan 14, 2020
jirikuncar
jirikuncar suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jirikuncar jirikuncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the semantic of retries argument.

lib/dogapi/common.rb Outdated Show resolved Hide resolved
lib/dogapi/common.rb Outdated Show resolved Hide resolved
lib/dogapi/common.rb Outdated Show resolved Hide resolved
lib/dogapi/common.rb Outdated Show resolved Hide resolved
@gzussa gzussa removed the stale Stale - Bot reminder label Jan 16, 2020
@gzussa gzussa requested a review from a team January 16, 2020 13:25
@gzussa gzussa added the changelog/Added Added features results into a minor version bump label Jan 16, 2020
@Azoam Azoam requested a review from jirikuncar January 17, 2020 17:43
@jirikuncar jirikuncar changed the title Adding function to deal with redirection of http requests Added function to deal with redirection of HTTP requests Jan 27, 2020
@jirikuncar jirikuncar added the community Community driven changes label Jan 27, 2020
@jirikuncar jirikuncar merged commit dd05748 into master Jan 27, 2020
@jirikuncar jirikuncar deleted the sam/handle_redirects branch January 27, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

Assignees

@jirikuncar jirikuncar

Labels
changelog/Added Added features results into a minor version bump community Community driven changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Azoam @jirikuncar @gzussa @dabcoder