Allow dynamic route mapping for discounts and ads #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevedatadog
approved these changes
Apr 6, 2022
| image: "ddtraining/storefront-fixed:latest" | ||
| - ADS_ROUTE=${ADS_ROUTE} | ||
| - DISCOUNTS_ROUTE=${DISCOUNTS_ROUTE} | ||
| image: "public.ecr.aws/x2b9z2t7/ddtraining/storefront-fixed:latest" |
There was a problem hiding this comment.
Should this be tagged with the associated release, rather than latest?
There was a problem hiding this comment.
This compose file is used for local development only, so I keep it tagged to latest so the most recent changes to storefront are always being tested if we're between releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13
This allows frontend to connect to the
adsanddiscountson a configurable path set at runtime via thedeploy/docker-compose/.envfile:The values default to the docker routes
http://advertisementsandhttp://discountsI've also updated the developer documentation to accurately reflect how to make a core change across all frontend versions.
How to test
deploy/docker-compose/.env, and start the app via thebaselinecompose file e.g.POSTGRES_USER=postgres POSTGRES_PASSWORD=postgres DD_API_KEY=[API KEY] make local-baseline-start