Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] fix gitlab jobs #173

Merged
merged 1 commit into from
Jan 29, 2024
Merged

[gitlab] fix gitlab jobs #173

merged 1 commit into from
Jan 29, 2024

Conversation

celenechang
Copy link
Contributor

What does this PR do?

An issue was noticed after merging #172

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@celenechang celenechang added bug Something isn't working tooling Issue linked to the repository tooling qa/skip-qa labels Jan 29, 2024
@celenechang celenechang requested review from a team as code owners January 29, 2024 20:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5234198) 63.10% compared to head (5feb3c8) 63.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   63.10%   63.23%   +0.12%     
==========================================
  Files          41       41              
  Lines        3098     3098              
==========================================
+ Hits         1955     1959       +4     
+ Misses       1023     1020       -3     
+ Partials      120      119       -1     
Flag Coverage Δ
unittests 63.23% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5234198...5feb3c8. Read the comment docs.

@celenechang celenechang merged commit 5d93a41 into main Jan 29, 2024
29 of 30 checks passed
@celenechang celenechang deleted the celene/fix_migration branch January 29, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qa/skip-qa tooling Issue linked to the repository tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants