[gitlab] update runners for build jobs #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celenechang
commented
Jan 26, 2024
| @@ -48,67 +48,75 @@ generate_code: | |||
|
|
|||
| build_eds_image_amd64: | |||
| stage: image | |||
| tags: ["runner:docker", "size:large"] | |||
| tags: | |||
| - "arch:amd64" | |||
There was a problem hiding this comment.
checking if we ought to use size:large tags for the new runners as well
There was a problem hiding this comment.
from inspecting our runner nodes i don't see any indication of a size tag or label
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 63.10% 63.23% +0.12%
==========================================
Files 41 41
Lines 3098 3098
==========================================
+ Hits 1955 1959 +4
+ Misses 1023 1020 -3
+ Partials 120 119 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
levan-m
approved these changes
Jan 29, 2024
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate Gitlab runners according to new processes
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.