Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker buildx to tag and push image for tagged commit #177

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

levan-m
Copy link
Contributor

@levan-m levan-m commented Apr 23, 2024

What does this PR do?

Trying to fix rc release failures by replacing

docker tag $TARGET_IMAGE $RELEASE_IMAGE && docker push $RELEASE_IMAGE

which tags and pushes current image if commit is tagged with a command using docker buildx

docker buildx imagetools create $TARGET_IMAGE --tag $RELEASE_IMAGE --push

latter is needed after this change #172

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@levan-m levan-m requested review from a team as code owners April 23, 2024 21:21
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation, tooling

@levan-m levan-m added the tooling Issue linked to the repository tooling label Apr 24, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@levan-m levan-m added this to the v0.10 milestone Apr 24, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@levan-m levan-m merged commit b5045f9 into main Apr 30, 2024
27 of 29 checks passed
@levan-m levan-m deleted the levan-m/fix-gitlab-tag-push-ci branch April 30, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa/skip-qa tooling Issue linked to the repository tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants