Upgrade controller-runtime, k8s dependencies and switch leader election lock to leases
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
levan-m
commented
May 20, 2024
| case len(namespaces) > 1: | ||
| // configure cluster-scoped with MultiNamespacedCacheBuilder | ||
| logger.Info("Manager will be watching multiple namespaces", namespaces) | ||
| opt.NewCache = func(config *rest.Config, opts cache.Options) (cache.Cache, error) { | ||
| opts.Namespaces = namespaces | ||
| // https://github.com/kubernetes-sigs/controller-runtime/commit/3e35cab1ea29145d8699259b079633a2b8cfc116 |
There was a problem hiding this comment.
I couldn't associate this change to specific release note but here is the change relevant to below
kubernetes-sigs/controller-runtime@3e35cab
levan-m
force-pushed
the
levan-m/k8s-dep-upgrades
branch
from
109b639
to
858a25e
Compare
levan-m
force-pushed
the
levan-m/k8s-dep-upgrades
branch
from
858a25e
to
a6b8b08
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
+ Coverage 63.10% 63.21% +0.10%
==========================================
Files 41 41
Lines 3098 3107 +9
==========================================
+ Hits 1955 1964 +9
- Misses 1023 1024 +1
+ Partials 120 119 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
levan-m
changed the title
controller-runtime to 0.16.0, k8s dependencies to 0.28.xcontroller-runtime, k8s dependencies and switch to leader election lock to leases
levan-m
changed the title
controller-runtime, k8s dependencies and switch to leader election lock to leases controller-runtime, k8s dependencies and switch leader election lock to leases
vboulineau
approved these changes
May 22, 2024
celenechang
approved these changes
May 22, 2024
levan-m
added a commit
that referenced
this pull request
May 22, 2024
…tion lock to `leases` (#186) * Checkpoint: build, docker-build, test; controller-runtime 0.15->0.16, k8s 0.27->0.28. * Use controller-runtime 0.16.0 instead of 0.16.6 due to incompatibility with new fake * update CRDs * Make `leases` default leaderElectionResourceLock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notable changes:
controller-runtime0.15.x -> 0.16.0 - didn't update to latest of 0.16.x asfakecaused test failures.leasesdefault leader election resource lock, as others are deprecated.0.16.0 release notes here.
kubernetes-sigs/controller-runtime#2407
kubernetes-sigs/controller-runtime#2422
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.