Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to set pod and container securityContext #83

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Add options to set pod and container securityContext #83

merged 2 commits into from
Nov 4, 2020

Conversation

nexuhan
Copy link

@nexuhan nexuhan commented Nov 4, 2020

What this PR does / why we need it:

Adds options to specify securityContext settings for both pods and containers to handle special capabilities or more stringent security policies.

Which issue this PR fixes

Fixes #82

Special notes for your reviewer:

This PR is based on an older PR (helm/charts#17274)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: Icelyn Jennings <icelynjennings@gmail.com>
@nexuhan nexuhan requested a review from a team as a code owner November 4, 2020 12:47
@nexuhan
Copy link
Author

nexuhan commented Nov 4, 2020

/assign @clamoriniere @xlucas

@vboulineau
Copy link
Contributor

LGTM, though you need to add the new options in values.yaml with empty default value. The doc generation will then generate the doc correctly.

@nexuhan
Copy link
Author

nexuhan commented Nov 4, 2020

Thank you @vboulineau. Docs checks now pass; merge when ready.

Signed-off-by: Icelyn Jennings <icelynjennings@gmail.com>
@nexuhan
Copy link
Author

nexuhan commented Nov 4, 2020

Squashed, removed containerSecurityContext fields proposed by original PR @vboulineau

@vboulineau vboulineau merged commit 67b9149 into DataDog:master Nov 4, 2020
@nexuhan nexuhan deleted the ddcontainersecurity branch November 4, 2020 17:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DD agent container securityContext field
3 participants