[kafka_consumer] Switch ZK example from string to list #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kazoo` 2.4 merged python-zk/kazoo#424 which means `kazoo` now supports a list of multiple endpoints, not just a single string. So updating the example conf file as a list is more readable than a string, and for most configuration options will require less munging of inputs.
|
@jeffwidman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @truthbk to be a potential reviewer. |
jeffwidman
changed the title
truthbk
approved these changes
Jul 28, 2017
There was a problem hiding this comment.
According to python-zk/kazoo@72a8d96 this should be seamless and appears backward compatible. 👍
gml3ff
pushed a commit
that referenced
this pull request
May 14, 2020
* Added ssl_ca_cert to vault template * Fix vault template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kazoo2.4 merged python-zk/kazoo#424 which meanskazoonow supports a list of multiple endpoints, not just a single string.So updating the example conf file as a list is more readable than a string, and for most configuration management setups will require less munging of inputs when assembling variables into a template.
Note: Requires #623 to be merged first