-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change directory parameter to optional #10051
Conversation
The |
The |
Changed for consistency Co-authored-by: Fanny Jiang <fanny.jiang@datadoghq.com>
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending the following suggestions (removing "please")!
What does this PR do?
This PR makes the directory parameter in the postfix check optional to keep backwards compatibility.
Motivation
In check version < 1.9, there wasn't any validation for the check, which allowed the check to work without setting a directory parameter. In the newest version (1.9) there's a validator that checks that directory is set and this breaks existing configuration in which
postqueue: true
is set and directory is omitted.Additional Notes
Also added some explaining text in the conf.yaml.example and updated the readme accordingly.
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached