Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for critical service check and fix namespace #10062

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Sep 6, 2021

Added a test for critical service check when the service is down
Found we were appending snowflake prefix twice

@hithwen hithwen requested a review from a team as a code owner September 6, 2021 15:37
@ghost ghost added the integration/snowflake label Sep 6, 2021
@coignetp coignetp changed the title Add test for critical service check and fix namespae Add test for critical service check and fix namespace Sep 6, 2021
@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #10062 (f763c33) into master (e39df44) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
snowflake 94.67% <100.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hithwen hithwen merged commit a7ab63f into master Sep 7, 2021
@hithwen hithwen deleted the js/minimal-snowflake-test branch September 7, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants