Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower warning to debug level #10414

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Lower warning to debug level #10414

merged 2 commits into from
Oct 15, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 14, 2021 •
edited
Loading

What does this PR do?

Lower logging level of missing process message from warning to debug.

Motivation

Follow up to #7045 to completely fix #7827.

Additional Notes

Comments from #7045 apply here too.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the integration/process label Oct 14, 2021
@mx-psi mx-psi marked this pull request as ready for review October 14, 2021 10:54
@mx-psi mx-psi requested review from a team as code owners October 14, 2021 10:54
@codecov
Copy link

codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #10414 (b45f6c2) into master (7c477f7) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Flag Coverage Δ
process 85.07% <0.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

KSerrania
KSerrania previously approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we also lower the level of the warning on line 288?

@mx-psi mx-psi requested a review from KSerrania October 14, 2021 12:29
@mx-psi mx-psi merged commit 530a6bf into master Oct 15, 2021
@mx-psi mx-psi deleted the mx-psi/lower-debug-level branch October 15, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSerrania KSerrania KSerrania approved these changes

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
integration/process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process monitor throws warnings on postgresql: Warning: Process 123 disappeared while scanning
3 participants
@mx-psi @KSerrania @sarah-witt