New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integration docs to include OpenMetrics V2 #10500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this seems to be an incomplete copy+paste from the RFC, it doesn't fit the context in which it now inhabits. Let's:
- Make a new directory
docs/developer/legacy
and moveprometheus.md
there. Do not include this in thenav
section ofmkdocs.yml
. - Rename
openmetricsv2.md
toopenmetrics.md
. - Write it from scratch to simply reflect the current state of things like we're doing for Open Metrics configs. See https://datadoghq.dev/integrations-core/base/databases/ for an example. The target audience is a person (likely teammate) implementing an Open Metrics-based check.
- Link to
../legacy/prometheus.md
at some point.
Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small feedback, mostly on styling for our processes.
Co-authored-by: Jorie Helwig <jorie.helwig@datadoghq.com>
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 docs 🎉
datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper.py
Outdated
Show resolved
Hide resolved
…scraper.py Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
What does this PR do?
This PR adds a new section for OpenMetricsV2. This also adds the IBM i architecture page in the navigation bar, since it was not included.
Motivation
Updating Istio documentation in #10304 and needed to link to a source of truth.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached