Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required config option #10629

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Fix required config option #10629

merged 1 commit into from
Nov 15, 2021

Conversation

coignetp
Copy link
Contributor

What does this PR do?

aci_url is not required if aci_urls is defined
pwd is not required if a cert is defined

Motivation

QA #8894

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested review from a team as code owners November 15, 2021 13:09
@codecov
Copy link

codecov bot commented Nov 15, 2021 •
edited

Codecov Report

Merging #10629 (60b7741) into master (e668209) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
cisco_aci 95.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@coignetp coignetp merged commit cb047e7 into master Nov 15, 2021
@coignetp coignetp deleted the paul/aci-fix-spec branch November 15, 2021 15:34
@fanny-jiang fanny-jiang added the category/bugfix For use during Agent Release period label Nov 15, 2021
fanny-jiang pushed a commit that referenced this pull request Nov 16, 2021
@coignetp @fanny-jiang
Fix required config option (#10629)
234a405 
(cherry picked from commit cb047e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period documentation integration/cisco_aci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coignetp @sarah-witt @fanny-jiang