Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support istio_agent metrics in sidecars #10702

Merged
merged 7 commits into from
Nov 30, 2021
Merged

Support istio_agent metrics in sidecars #10702

merged 7 commits into from
Nov 30, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Support istio_agent_ metrics from the merged metrics port

Motivation

Customer support

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners November 22, 2021 22:54
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

alai97
alai97 previously approved these changes Nov 22, 2021
View reviewed changes
fanny-jiang
fanny-jiang requested changes Nov 22, 2021
View reviewed changes
istio/tests/test_istio_v1.py Outdated Show resolved Hide resolved
fanny-jiang
fanny-jiang previously approved these changes Nov 23, 2021
View reviewed changes
@fanny-jiang fanny-jiang self-requested a review November 23, 2021 01:17
@codecov
Copy link

codecov bot commented Nov 23, 2021 •
edited
Loading

Codecov Report

Merging #10702 (7dc7aea) into master (6fb971c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
istio 77.46% <100.00%> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ChristineTChen ChristineTChen merged commit 9b5b25a into master Nov 30, 2021
@ChristineTChen ChristineTChen deleted the cc/fix-istio-link branch November 30, 2021 16:29
cswatt pushed a commit that referenced this pull request Jan 5, 2022
@ChristineTChen @cswatt
Support istio_agent metrics in sidecars (#10702)
8a2830c 
* Support istio_agent metrics in sidecars

* Fix link in README

* Add test

* update metadata.csv

* Fix validation

* use legacy instance

* Remove legacy test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@alai97 alai97 Awaiting requested review from alai97

Assignees
No one assigned
Labels
documentation integration/istio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristineTChen @fanny-jiang @alai97