Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default field name of schema #10714

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Fix default field name of schema #10714

merged 2 commits into from
Nov 23, 2021

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented Nov 23, 2021 •
edited
Loading

What does this PR do?

  • Fixes the field name for schema
  • Allows users to optionally set the schema config option
  • Currently, if schema is not specified, an error is thrown when it should not:
    AttributeError: module 'datadog_checks.snowflake.config_models.defaults' has no attribute 'instance_schema_'

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@sarah-witt sarah-witt marked this pull request as ready for review November 23, 2021 17:10
@sarah-witt sarah-witt requested a review from a team as a code owner November 23, 2021 17:10
@fanny-jiang fanny-jiang added category/bugfix For use during Agent Release period changelog/Fixed labels Nov 23, 2021
@sarah-witt sarah-witt changed the title Fix schema default field name Fix default field name of schema Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021 •
edited
Loading

Codecov Report

Merging #10714 (c6f101c) into master (1f32928) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
snowflake 93.60% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt merged commit 9715c1e into master Nov 23, 2021
@sarah-witt sarah-witt deleted the sarah/fix-snowflake-default branch November 23, 2021 21:56
fanny-jiang pushed a commit that referenced this pull request Nov 24, 2021
@sarah-witt @fanny-jiang
Update default field name (#10714)
b003757 
(cherry picked from commit 9715c1e)
@sarah-witt sarah-witt mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period integration/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarah-witt @ofek @fanny-jiang