Add current timestamp to SQLServer activity collection #10786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
alexandre-normand
previously approved these changes
Dec 2, 2021
alexandre-normand
approved these changes
Dec 3, 2021
jmeunier28
commented
Dec 3, 2021
| @@ -45,7 +45,7 @@ def dbm_instance(instance_docker): | |||
| def instance_sql_msoledb_dbm(instance_sql_msoledb): | |||
| instance_sql_msoledb['dbm'] = True | |||
| instance_sql_msoledb['min_collection_interval'] = 1 | |||
| instance_sql_msoledb['query_metrics'] = {'enabled': True, 'run_sync': True, 'collection_interval': 0.1} | |||
| instance_sql_msoledb['query_metrics'] = {'enabled': True, 'run_sync': True, 'collection_interval': 2} | |||
There was a problem hiding this comment.
The test_statement_metrics_and_plans_windows test has been super flakey with CI so I tried increasing the collection interval for this, which should allow us catch metrics in the test
sarah-witt
approved these changes
Dec 3, 2021
cswatt
pushed a commit
that referenced
this pull request
Jan 5, 2022
* Add current timestamp to SQLServer activity collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to this #10782, which added ISO timestamp formatting for tx begin and query start times. In the backend, we were calculating the difference based off the unix timestamp collected by the agent, but its possible for there to be drift between these two things. The most accurate calculation will only be possible if we collect the
CURRENT_TIMESTAMPfrom the server itselfMotivation
DBM SQLServer Active Sessions beta feedback / Follow up PR from #10610
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached