Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value for instance level oid_batch_size #11018

Merged

Conversation

AlexandreYang
Copy link
Member

What does this PR do?

Fix default value for instance level oid_batch_size

Motivation

Instance level oid_batch_size is only available for corecheck SNMP integration and the default for oid_batch_size for corecheck SNMP integration is 5: https://github.com/DataDog/datadog-agent/blob/main/pkg/collector/corechecks/snmp/checkconfig/config.go#L30-L33

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ghost ghost added the documentation label Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #11018 (adbf96b) into master (8a0ec3f) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
snmp 88.09% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlexandreYang
Copy link
Member Author

/azp run PR Changes

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AlexandreYang AlexandreYang merged commit 36dfc5c into master Jan 5, 2022
@AlexandreYang AlexandreYang deleted the alex/snmp_fix_default_value_for_instance_oid_batch_size branch January 5, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants