Add aggregate_last_24_hours option #11157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
This reverts commit 8d5b0c3.
alai97
previously approved these changes
Jan 18, 2022
sarah-witt
requested changes
Jan 19, 2022
| @@ -141,6 +141,14 @@ files: | |||
| - snowflake.billing | |||
| - snowflake.storage | |||
| - snowflake.logins | |||
| - name: use_deprecated_aggregation | |||
There was a problem hiding this comment.
what do you think about making the option more descriptive, something like aggregate_24_hours? There could be instances where someone would prefer aggregating on the current day
There was a problem hiding this comment.
I was hesitant to use something like aggregate_24_hours ; as aggregate_24_hours: false does not give that much info on how the queries are aggregated. I'll change the name of the option though
There was a problem hiding this comment.
would aggregate_last_24_hours make make more sense?
coignetp
changed the title
sarah-witt
reviewed
Jan 19, 2022
sarah-witt
reviewed
Jan 20, 2022
Co-authored-by: Sarah Witt <sarah.witt@datadoghq.com>
coignetp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The queries were aggregating entries
since the beginning of the day, this PR add a config flag to aggregate the entries inthe last 24 hoursinstead.Motivation
Since some tables could have a 3 hours latency, the queries
since the beginning of the daycould be empty and leads to missing metrics. Aggregating the entries in the last 24 hours instead is more consistent.Additional Notes