Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration error for custom queries #11185

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Fix configuration error for custom queries #11185

merged 2 commits into from
Jan 21, 2022

Conversation

coignetp
Copy link
Contributor

What does this PR do?

An instance can be configured to run custom queries only, so metric_groups can be set as empty

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested a review from a team as a code owner January 21, 2022 11:23
sarah-witt
sarah-witt approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@coignetp coignetp merged commit 9309e66 into master Jan 21, 2022
@coignetp coignetp deleted the paul/sf=fix-custom branch January 21, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
integration/snowflake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coignetp @sarah-witt