Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for percentile aggregations for NGINX integration response time metrics #11252

Merged
merged 42 commits into from
Feb 3, 2022
Merged

Allow for percentile aggregations for NGINX integration response time metrics #11252

merged 42 commits into from
Feb 3, 2022

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Feb 1, 2022 •
edited
Loading

Customer requested to be able to do percentile aggregations on response time metrics.
This PR also splits plus api unit tests into their own file. In those test the number of asserted metrics has changed

sarah-witt and others added 30 commits November 9, 2021 00:46
@sarah-witt
Add test data and limit_reqs endpoint
22d1d8c
@sarah-witt
Add support for new endpoints in check
082073a
@sarah-witt
Merge branch 'master' into sarah/nginx-v6
80549e2
@sarah-witt
Update metadata with new metrics
ab85b55
@sarah-witt
add more tests for tags
a5865ab
@hithwen
Read all config in init
b093637
@hithwen
Simplify check method
c7c89f7
@hithwen
Fix unit tests
62d0a5d
@hithwen
Merge branch 'js/refactor-nginx' into js/refactor-nginx-2
639571c
@hithwen
Do not pass around instance attributes & minor refactors
428e7e5
@hithwen
Merge branch 'js/refactor-nginx' into js/refactor-nginx-2
27e56bc
@hithwen
Style fix
cf8a97c
@hithwen
Merge branch 'js/refactor-nginx' into js/refactor-nginx-2
5541757
@hithwen
Fix unit tests
3de1ada
@hithwen
Merge branch 'js/refactor-nginx' into js/refactor-nginx-2
543082e
@hithwen
Merge remote-tracking branch 'origin/master' into js/refactor-nginx-2
9c91c5d
@sarah-witt
Apply refactoring changes
a198d3f
@sarah-witt
Add more tests and http limit conns endpoint
51fb1d5
@sarah-witt
Add tests for all plus api versions
ad9e1c3
@sarah-witt
Reformat code and fix typos
a69fd4e
@sarah-witt
Remove unneeded mappings
eba4919
@sarah-witt
Remove unneeded mapping and test fixture
4b145fc
@sarah-witt
Properly handle metrics that should be counts
a23af73
@sarah-witt
Change more metrics to count
c3e6fe6
@sarah-witt
Fix short names of metrics
cedecf2
@sarah-witt
Update style and add assertion for all count metrics
a32393e
@sarah-witt
Update conf.example with new description
f6fd2ee
@sarah-witt
Update test folder structure and add mapping for plus api endpoints
6372505
@sarah-witt
Assert metadata in all tests
9fe03b3
@sarah-witt
Add missing count metrics, assert metrics covered, and refactor tests
63c10f5
@ghost ghost added the integration/nginx label Feb 1, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@hithwen hithwen force-pushed the js/AI-2061-add-distribution-metrics branch from fa37396 to e342100 Compare February 1, 2022 12:15
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@hithwen hithwen changed the title Add distribution metrics Allow for percentile aggregations for NGINX integration Feb 1, 2022
@hithwen hithwen changed the title Allow for percentile aggregations for NGINX integration Allow for percentile aggregations for NGINX integration response time metrics Feb 1, 2022
@hithwen hithwen marked this pull request as ready for review February 1, 2022 12:51
@hithwen hithwen requested a review from a team as a code owner February 1, 2022 12:51
sarah-witt
sarah-witt reviewed Feb 2, 2022
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

nginx/metadata.csv Outdated Show resolved Hide resolved
nginx/datadog_checks/nginx/metrics.py Outdated Show resolved Hide resolved
nginx/datadog_checks/nginx/nginx.py Outdated Show resolved Hide resolved
nginx/datadog_checks/nginx/nginx.py Outdated Show resolved Hide resolved
nginx/datadog_checks/nginx/nginx.py Outdated Show resolved Hide resolved
nginx/tests/test_plus_api.py Show resolved Hide resolved
nginx/datadog_checks/nginx/metrics.py Show resolved Hide resolved
@hithwen hithwen requested review from sarah-witt and a team February 3, 2022 14:30
@hithwen hithwen merged commit 6bb4a45 into master Feb 3, 2022
@hithwen hithwen deleted the js/AI-2061-add-distribution-metrics branch February 3, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
integration/nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hithwen @sarah-witt