Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traffic_server_url tag #11862

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Add traffic_server_url tag #11862

merged 1 commit into from
Apr 20, 2022

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Adds a traffic_server_url tag to all metrics and service checks

Motivation

Most checks send a basic endpoint tag, and there are cases when a traffic server host can be monitored remotely.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@sarah-witt sarah-witt marked this pull request as ready for review April 20, 2022 17:27
@sarah-witt sarah-witt requested a review from a team as a code owner April 20, 2022 17:27
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #11862 (68a2ac0) into master (b4110f6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
traffic_server 96.13% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 merged commit c0845a4 into master Apr 20, 2022
@steveny91 steveny91 deleted the sarah/traffic_server_url_tag branch April 20, 2022 19:44
steveny91 pushed a commit that referenced this pull request Apr 20, 2022
@steveny91 steveny91 added the category/improvement For use during Agent Release period label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/improvement For use during Agent Release period integration/traffic_server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants