Update mapping and tags in README.md #11967
Conversation
Adjusting airflow matching pattern to include missing `airflow.`, as well as unifying tags for dag and task id (dag_id / task_id) as they were different between mapping
|
Hallo, thanks for your contribution. Can you update it on line 311 too? |
airflow/README.md
Outdated
| name: "airflow.scheduler.tasks.starving" | ||
| - match: sla_email_notification_failure | ||
| - match: airflow.sla_email_notification_failure |
There was a problem hiding this comment.
should this match also be wrapped in quotes?
| - match: airflow.sla_email_notification_failure | |
| - match: 'airflow.sla_email_notification_failure' |
There was a problem hiding this comment.
good catch, thank you, updated!
airflow/README.md
Outdated
| @@ -108,11 +108,11 @@ Connect Airflow to DogStatsD (included in the Datadog Agent) by using the Airflo | |||
| name: "airflow.pool.open_slots" | |||
| tags: | |||
| pool_name: "$1" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
updated, hope i got the last one right though
|
@sarah-witt @fanny-jiang is there anything else you would like me to change? by the way, regardless to this change, i think that you are missing documentation on how to properly configure dd agent to collect airflow worker's tasks logs in Kubernetes (specific annotation, mounting volume and a new log pipeline). |
|
Hi @moshederri there seems to be a small merge conflict. We can approve and merge after resolving this merge conflict. |
* Update README.md Adjusting airflow matching pattern to include missing `airflow.`, as well as unifying tags for dag and task id (dag_id / task_id) as they were different between mapping * Update README.md * Update README.md * Update datadog_values.yaml * Update test_check_metrics_up_to_date.py 9c5ac5e
Adjusting airflow matching pattern to include missing
airflow., as well as unifying tags for dag and task id (dag_id / task_id) as they were different between mappingWhat does this PR do?
Fix invalid mappings as well as unify tags
Motivation
Using the previous version did not match all metrics as well as forced us to use two different template variables (for example, dagid and dag_id)