Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Jose's testing style #13424

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Apply Jose's testing style #13424

merged 1 commit into from
Nov 30, 2022

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Nov 29, 2022 •
edited
Loading

What does this PR do?

This PR applies @jose-manuel-almaza 's testing changes from https://github.com/DataDog/integrations-core/compare/jose/cloudera into this branch.

We split up his PR into two separate PRs, this one (for testing) and another one for metric collection.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@yzhan289 yzhan289 requested review from a team as code owners November 29, 2022 23:01
@yzhan289 yzhan289 changed the base branch from master to az/cloudera November 29, 2022 23:02
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

jose-manuel-almaza
jose-manuel-almaza reviewed Nov 30, 2022
View reviewed changes
cloudera/tests/test_integration.py

@pytest.mark.usefixtures('dd_environment')
@pytest.mark.integration
def test_given_api_v12_endpoint_when_check_runs_then_service_check_ok_and_metrics(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check this if we are not going to support version 5 (api v12)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will ask in meeting on Monday.

@yzhan289 yzhan289 merged commit fa93229 into az/cloudera Nov 30, 2022
@yzhan289 yzhan289 deleted the az/jose-cloudera-testing branch November 30, 2022 16:50
yzhan289 added a commit that referenced this pull request Dec 2, 2022
@yzhan289
Apply testing changes (#13424)
ed09437
yzhan289 added a commit that referenced this pull request Dec 23, 2022
@yzhan289 @ofek
@jose-manuel-almaza @buraizu
Add Cloudera integration (#13244)
28ad542 
* Cloudera template

* Outline plan for integration

* Set up init metric and test env

* Add common.py

* Outline check and include tests

* Clean up check

* Update cloudera/pyproject.toml

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>

* Drop support for Python 2

* Clean up timeseries metrics

* Add more metrics

* Add more metrics

* Implement host service check and fix style

* Change how cloudera client is created

* Add caddy to mock API output

* Add caddy test API outputs

* Apply Jose's metric and health check collection style (#13423)

* First commit

* Added docker-compose file

* Match current PR

* Match PR

* Fix style

* Refactor

* Revert any test changes

* Spacing

* Revert unnecessary changes

* Spacing

Co-authored-by: Jose Manuel Almaza <josemanuel.almaza@datadoghq.com>

* Apply testing changes (#13424)

* Apply changes from Jose's branch

* Add Jose's new host metrics

* Fix validations

* Add license

* Fix properties

* Change to use caddy docker image

* Start events implementation

* Unit tests working

* Map to 80 local port not recommended

* Added url to debug log

* Remove events implementation

* Fixed integration tests

* Fix license validation

* Remove unused constants

* Add e2e test

* Use master's change

* Fix e2e and integration test style

* Add temporary gitlab change

* Temporarily add default dep

* Wait for Cloudera is up

* Refactor Cloudera (#13460)

* Add native host metrics

* Remove unused function name

* Refactor Cloudera

* Remove native metric support

* Fix style

* Update refactor from feedback

* Update service checks and update metadata.csv

* Fixed missing coverage

* Added 'io' to VALID_UNIT_NAMES

* Added some tag checks to tests

* Fix service checks and add comma

* Add native metrics (#13474)

* Add native metrics

* Fix e2e test

* Move metadata.csv change to separate branch

* Renamed some methods

* Fixed problem merging metrics

* Fixed unit tests

Co-authored-by: Jose Manuel Almaza <josemanuel.almaza@datadoghq.com>

* Clean up

* Add version collection

* Add back service check for can_connect

* Update README and add pictures

* Move images directory

* Add custom tag support

* Fix style

* Add custom tag tests

* Fix test for e2e test

* Run cloudera manager requests in parallel (#13499)

* Added multithread

* Add hidden config for max connection pool size

* Added 'dd_environment' to test_metadata

* Update config

Co-authored-by: Andrew Zhang <andrew.zhang@datadoghq.com>

* Fix config param

* Remove io as metric type

* Apply suggestions from code review

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

* Apply suggestions

* Apply suggestion

* Fix style

* Update cloudera/README.md

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

* Update cloudera/README.md

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

* Apply suggestions

* Fix tests

* Fix style

* Fix formatting

* Apply suggestion and move credentials to init_config

* Update Cloudera README for collecting metrics

* Fix README

* Fix README

* Apply suggestions from code review

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Co-authored-by: Jose Manuel Almaza <josemanuel.almaza@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
github-actions bot pushed a commit that referenced this pull request Dec 23, 2022
@yzhan289 @ofek @jose-manuel-almaza
Add Cloudera integration (#13244)
f966425 
* Cloudera template

* Outline plan for integration

* Set up init metric and test env

* Add common.py

* Outline check and include tests

* Clean up check

* Update cloudera/pyproject.toml

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>

* Drop support for Python 2

* Clean up timeseries metrics

* Add more metrics

* Add more metrics

* Implement host service check and fix style

* Change how cloudera client is created

* Add caddy to mock API output

* Add caddy test API outputs

* Apply Jose's metric and health check collection style (#13423)

* First commit

* Added docker-compose file

* Match current PR

* Match PR

* Fix style

* Refactor

* Revert any test changes

* Spacing

* Revert unnecessary changes

* Spacing

Co-authored-by: Jose Manuel Almaza <josemanuel.almaza@datadoghq.com>

* Apply testing changes (#13424)

* Apply changes from Jose's branch

* Add Jose's new host metrics

* Fix validations

* Add license

* Fix properties

* Change to use caddy docker image

* Start events implementation

* Unit tests working

* Map to 80 local port not recommended

* Added url to debug log

* Remove events implementation

* Fixed integration tests

* Fix license validation

* Remove unused constants

* Add e2e test

* Use master's change

* Fix e2e and integration test style

* Add temporary gitlab change

* Temporarily add default dep

* Wait for Cloudera is up

* Refactor Cloudera (#13460)

* Add native host metrics

* Remove unused function name

* Refactor Cloudera

* Remove native metric support

* Fix style

* Update refactor from feedback

* Update service checks and update metadata.csv

* Fixed missing coverage

* Added 'io' to VALID_UNIT_NAMES

* Added some tag checks to tests

* Fix service checks and add comma

* Add native metrics (#13474)

* Add native metrics

* Fix e2e test

* Move metadata.csv change to separate branch

* Renamed some methods

* Fixed problem merging metrics

* Fixed unit tests

Co-authored-by: Jose Manuel Almaza <josemanuel.almaza@datadoghq.com>

* Clean up

* Add version collection

* Add back service check for can_connect

* Update README and add pictures

* Move images directory

* Add custom tag support

* Fix style

* Add custom tag tests

* Fix test for e2e test

* Run cloudera manager requests in parallel (#13499)

* Added multithread

* Add hidden config for max connection pool size

* Added 'dd_environment' to test_metadata

* Update config

Co-authored-by: Andrew Zhang <andrew.zhang@datadoghq.com>

* Fix config param

* Remove io as metric type

* Apply suggestions from code review

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

* Apply suggestions

* Apply suggestion

* Fix style

* Update cloudera/README.md

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

* Update cloudera/README.md

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

* Apply suggestions

* Fix tests

* Fix style

* Fix formatting

* Apply suggestion and move credentials to init_config

* Update Cloudera README for collecting metrics

* Fix README

* Fix README

* Apply suggestions from code review

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
Co-authored-by: Jose Manuel Almaza <josemanuel.almaza@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com> 28ad542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose-manuel-almaza jose-manuel-almaza jose-manuel-almaza left review comments

Assignees
No one assigned
Labels
changelog/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yzhan289 @jose-manuel-almaza