Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect the number of cpu cores using psutil.cpu_count() #13483

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

steveny91
Copy link
Contributor

@steveny91 steveny91 commented Dec 8, 2022

What does this PR do?

Small change in logic in how we collect number of cpu cores. We used to count the length of CPU times, but there's a built in function in psutil that returns the count.

Was initially part of #13349 but it was better to split them up.

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Label changelog/Changed was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed label.

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Label changelog/Changed was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed label.

@steveny91 steveny91 marked this pull request as ready for review December 8, 2022 20:03
@steveny91 steveny91 requested a review from a team as a code owner December 8, 2022 20:03
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #13483 (e707143) into master (d087f87) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
system_core 90.90% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 merged commit e8ff949 into master Dec 8, 2022
@steveny91 steveny91 deleted the sy/system-core-count branch December 8, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants