Fix duplicate events bug

[yzhan289]

What does this PR do?

This PR simplifies the event collection logic since it was causing a bug where the same event was being sent over and over again rather than new events.

Motivation

Bug

Additional Notes

Review checklist (to be filled by reviewers)

• Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
• PR title must be written as a CHANGELOG entry (see why)
• Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
• PR must have changelog/ and integration/ labels attached
• If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

[github-actions]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

[steveny91]

What was the cause of the duplicated events? Was it not including a the latest event timestamp in the query?

EVENT_PATH = "events?timestamp__gte={}&timestamp__lt={}"

[yzhan289]

What was the cause of the duplicated events? Was it not including a the latest event timestamp in the query?

EVENT_PATH = "events?timestamp__gte={}&timestamp__lt={}"

The main cause is that the Silk environment is around 12 minutes ahead of the actual time. Since in my original implementation, I didn't include timestamp__lt={}, it would keep collecting the same event for 12 minutes since it uses the Agent's timestamp.

There was likely duplication also due to the multiple variables I juggled when determining the event timestamp, like having last_event_time, self.latest_event_query and collect_events_start_time. I'm simplifying it here to make it easier to understand.

[github-actions]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

[github-actions]

Test Results

  4 files    4 suites   15s ⏱️
24 tests 24 ✔️ 0 💤 0 ❌
50 runs  48 ✔️ 2 💤 0 ❌

Results for commit e1f25f9.

[codecov]

Codecov Report

Merging #14020 (e1f25f9) into master (2cbd09e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag	Coverage Δ
silk	93.69% <100.00%> (+0.18%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.