Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow typed-ast to work for python3.11 #14689

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Allow typed-ast to work for python3.11 #14689

merged 1 commit into from
Jun 6, 2023

Conversation

swang392
Copy link
Contributor

@swang392 swang392 commented Jun 6, 2023

What does this PR do?

typed-ast previously only worked on older Python versions. I added a line that uses a newer version of typed-ast for newer Python versions.

Motivation

I was unable to run the style checks on my computer because I was using python3.11 and it wasn't compatible.

Additional Notes

python/typed_ast#167 -- this is our use case

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@swang392 swang392 requested a review from a team as a code owner June 6, 2023 20:26
@ghost ghost added the dev_package label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #14689 (26a3322) into master (190e8ea) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 82.75% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test Results

    4 files      4 suites   13m 33s ⏱️
424 tests 424 ✔️   0 💤 0
948 runs  915 ✔️ 33 💤 0

Results for commit 26a3322.

@swang392 swang392 merged commit 4eb2a1d into master Jun 6, 2023
32 of 33 checks passed
@swang392 swang392 deleted the swang392/style-fix branch June 6, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants