-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct checking instance type of get data response #15554
Conversation
fc07436
to
b553bfa
Compare
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, just left one question 🙂
3e21a7f
to
b553bfa
Compare
b553bfa
to
576abf9
Compare
Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
What does this PR do?
_get_data
generic exception handler was incorrectly checking forresp
variable which would always result inFalse
when the status code is not in successful rangeI believe the intent was to ensure the presence of
resp
variable to avoid an exception inside the generic exception handlerAs a result, a critical service check was sent whenever http request in
_get_data
fails leading to support ticket AGENT-10055This change ensures that the correct existence of
resp
variable and the relevant status code, so that auth error is raised as per expectationsMotivation
AGENT-10055
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.