Prevent aggregate_last_24_hours option from affecting global state
#16033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
drichards-87
previously approved these changes
Oct 17, 2023
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
steveny91
approved these changes
Oct 17, 2023
|
💪 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes a bug causing instance-specific configuration affecting all instances by avoiding modification of global variables.
Motivation
A bug was found where instances with
aggregate_last_24_hoursset totruewould still be seen to be using thedate_truncfunction in the query, which turned out to be because of other instances on the same Agent, with that setting set tofalse, were influencing global behavior.AGENT-10283
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.