Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python win32_event_log check implementation #16108

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

clarkb7
Copy link
Contributor

@clarkb7 clarkb7 commented Oct 30, 2023

What does this PR do?

Deprecate the Python win32_event_log implementation, add legacy_mode_v2 option to enable using it if necessary.

See DataDog/datadog-agent#20701 for the new check implementation

Motivation

Part of effort to consolidate the event log collection implementations.

https://datadoghq.atlassian.net/browse/WINA-519

Additional Notes

The Python WMI implementation (legacy_mode: true) is still the default for backwards compatibility purposes. Thus legacy_mode: false must still be set (see #15907).

WMI implementation:

  • no options set, or legacy_mode: true explicitly set

Python Event Log implementation

  • legacy_mode_v2: true explicitly set (it is not necessary to also explicitly set legacy_mode: false)

Go Event Log implementation

  • legacy_mode: false explicitly set

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #16108 (a57acc0) into master (fe87853) will increase coverage by 0.11%.
Report is 12 commits behind head on master.
The diff coverage is 96.15%.

Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?
win32_event_log 87.34% <96.15%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Test Results

    2 files      2 suites   50s ⏱️
123 tests 123 ✔️ 0 💤 0
215 runs  215 ✔️ 0 💤 0

Results for commit a57acc0.

♻️ This comment has been updated with latest results.

@clarkb7 clarkb7 force-pushed the branden.clark/event-log-skip-new branch from 5c69cff to 82279e9 Compare November 8, 2023 00:47
@clarkb7 clarkb7 changed the title Skip newer win32_event_log configurations Deprecate Python win32_event_log check implementation Nov 8, 2023
@ghost ghost added the documentation label Nov 8, 2023
@clarkb7 clarkb7 marked this pull request as ready for review November 8, 2023 06:43
@clarkb7 clarkb7 requested review from a team as code owners November 8, 2023 06:43
@julien-lebot julien-lebot merged commit cc63b0f into master Nov 10, 2023
40 checks passed
@julien-lebot julien-lebot deleted the branden.clark/event-log-skip-new branch November 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants